On Feb 20, 2009, at 15:54 , Christian Ohm wrote:

On Friday, 20 February 2009 at 19:34, Cristian Greco wrote:
do you agree with closing this bug report with the next upload of the
library?

This bug is only related to the lack of documentation about the
storage_mode_allocate feature of the library, which has been fixed in
latest release.

Actually this bug was about the preallocation which didn't work (or wasn't meant to be implemented though the documentation told otherwise), so changing to "wishlist: allow file preallocation" would be better imo (and perhaps also a "qbittorrent: 'pre-allocate files' option doesn't preallocate files" bug, since
that was what my original complaint was about).

Though now I don't really understand the difference between storage_mode_sparse and storage_mode_allocate. _sparse is the same as _allocate, except that it doesn't work on filesystems that don't support sparse files? Doesn't really make sense to have the two options then, imo (in addition to the fact that the
name of _allocate is now a bit misleading).

FYI,

In trunk version of libtorrent, full file allocation is implemented on windows (by not making files sparse), on BSD/Darwin by setting the F_PREALLOCATE fcntl(), and on linux (or systems that don't have that fcntl defined) by using posix_preallocate().

--
Arvid Norberg





--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to