On Fri, Feb 06, 2009 at 02:56:38PM +0100, Marcus Better wrote: > Package: uniutils > Version: 2.25-3 > Severity: normal > > The "uniname -V" command returns an error status regardless of the > input file, contrary to what is documented in the manual page. > > ~$ uniname -V /dev/null || echo $? > 1
Hi Bill, This is a bug in uniname reported against version 2.25 but I can reproduce it with the latest (2.26). Attached a patch that attempts to fix the problem. Please check the comments inside the patch. If you think it's OK, I'll upload a fixed version to Debian. Cheers, -- GPG-Key: 0xA3FD0DF7 - 9F73 032E EAC9 F7AD 951F 280E CB66 8E29 A3FD 0DF7 Debian User and Developer. Homepage: www.foolab.org
diff -Naur uniutils-2.26.orig/uniname.c uniutils-2.26/uniname.c
--- uniutils-2.26.orig/uniname.c 2008-04-04 05:01:51.000000000 +0300
+++ uniutils-2.26/uniname.c 2009-02-07 16:13:47.000000000 +0200
@@ -431,7 +431,11 @@
}
if(c > UNI_MAX_UTF32){
(void)HandleReadError(c,rawptr,InputLineNumber,Current_Char_Offset,Current_Byte_Offset-UCBytes);
- exit(1);
+ /*
+ * HandleReadError will return only if we reach the end of file so it's
+ * save to exit with a 0 status.
+ */
+ exit(0);
}
exit(0);
}
signature.asc
Description: Digital signature
