On Wed, Jan 28, 2009 at 08:04:20PM +0100, Andreas Henriksson wrote: > Hello! > > I had a really quick look and there seems to be several issues. > > Next after parsing the command line options, the server forks and kills > off the parent (in wzdftpd/wzd_main.c line 402). This leaves no room for > returning a proper error/exit code if something in the startup process > fails.
Hi, This is right, the first process forks and exits (so it does not get the return code). Suggestions accepted for a better way. > > The server doesn't seem to have any support for writing a pidfile on > it's own. Instead the start-stop-daemon feature is used in the init.d This is wrong grep pid_file /etc/wzdftpd/wzd.cfg pid_file = /var/run/wzdftpd/wzdftpd.pid wzdftpd can manage the pid file itself. > script. There seems to be several issues here: > > First the path to the pidfile is not consistently used > (/var/run/$NAME.pid v. /var/run/$NAME/$NAME.pid). ok, this is a bug. > > The second issue being, can start-stop-daemon really write a useful > pidfile when the process it starts will terminate right away? The > pidfile should contain the child pid, not the parent pid, since the > child is the actual server here. Yes. I'll see if using the internal pid_file feature fix all these problems, and upload a new version. > > The third issue is that this setup relies on debians default > configuration of a /var/run on persistant storage, since > the /var/run/wzdftpd/ directory is (only) created in the postinst > instead of the init.d script. Ubuntu has switched the default and as > suspected that bug has been fixed there. You can get the patch from > http://patches.ubuntu.com/w/wzdftpd/wzdftpd_0.8.3-5.1ubuntu1.patch which > will also fix up a dependency issue (postgresql vs postgresql-client). ok, I will fix this as well > > Popcon tells me there are only 28 people with this package installed and > 3 recently using it. Maybe we should consider removal? I'd prefer not. Cheers, Pierre -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
