Bug#511978: Missing mode argument to two open() calls with O_CREAT

[James Westby]

Package: vobcopy
Version: 1.1.0-1
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu jaunty ubuntu-patch

Hi,

When calling open() with the O_CREAT flag it is required to specify
the mode argument. Most places in vobcopy do this, but there are two
calls that don't. The attached patch corrects this, please consider
applying it.

Thanks,

James

diff -u vobcopy-1.1.0/debian/changelog vobcopy-1.1.0/debian/changelog
only in patch2:
unchanged:
--- vobcopy-1.1.0.orig/vobcopy.c
+++ vobcopy-1.1.0/vobcopy.c
@@ -519,7 +519,7 @@
       strcpy( tmp_path, pwd );
       strcat( tmp_path, "vobcopy.bla" );
       fprintf( stderr, "[Hint] Quiet mode - All messages will now end up in 
%s\n", tmp_path );
-      if ( ( temp = open( tmp_path , O_CREAT | O_EXCL ) ) == -1 )
+      if ( ( temp = open( tmp_path , O_CREAT | O_EXCL , 0644 ) ) == -1 )
        {
          printf( "[Error] Error: %s\n", strerror( errno ) );
          if ( errno == EEXIST )
@@ -575,7 +575,7 @@
       strcat( logfile_name, VERSION );
       strcat( logfile_name, ".log" );
       strcat( logfile_path, logfile_name );
-      if ( ( temp = open ( logfile_path , O_CREAT | O_EXCL ) ) == -1 )
+      if ( ( temp = open ( logfile_path , O_CREAT | O_EXCL , 0644 ) ) == -1 )
        {
          printf( "[Error] Error: %s\n", strerror( errno ) );
          if ( errno == EEXIST )