On Fri, 2 Jan 2009, Jonathan Wiltshire wrote:

> On Fri, Jan 02, 2009 at 12:11:34AM +0100, Cristian Ionescu-Idbohrn wrote:
> > The attched patch should fix a few bugs:
> >
> > + use http instead of ftp to access ftp.netbsd.org; addresses the
> >   reported bug
> > + fixes a bug in the openbsd sub
> > + fixes a bug in the fink sub
> >
> > and adjust/correct some regex and layout inconsistancies.  Cleans up
> > whitespace damage too.
>
> Cristian
>
> Thanks for your patch (I was just investigating this bug when I got
> sick). As soon as I'm well enough again I will apply the bug fixes, and
> leave the layout and whitespace to upstream, though I agree it makes the
> expressions much easier to read.

Jonathan,

I see you missed 3 more bug fixes in the patch I sent earlier:
Here comes another patch (whitespace diffs ignored).  Fixes:

  # exact match
  sub fink, hunk #11

To reproduce, run: # whohas -d fink keychain

  # combos -> combos_freebsd
  sub netbsd, hunk #19
  sub openbsd, hunk #20

To see what I mean, have a look at your cache
~/.whohas/{NetBSD,OpenBSD_4.4}.list.
To reproduce, run: # whohas -d openbsd,netbsd keychain


Cheers,

-- 
Cristian

Attachment: whohas.2.patch.gz
Description: Binary data

Reply via email to