Gian Piero Carrubba wrote: > The attached patch adds support for using darcs as backend. While darcs > isn't the best choice for etckeeper (because of lack of support for > file permissions - namely the exec bit - and simbolic links), it can be > handy for people like me that use a vcs only once in a while and are > used to darcs.
Thanks for working on this.
+ printf "%s\n" "find $NOVCS -type l -print | xargs rm -f {} \\;"
I don't think this is safe. It could delete symlinks that are in the tree but
not
committed.
+ find $NOVCS -type l -print | sort | while read link; do
+ dest=$( readlink "$link" )
+ printf "ln -s '%s' '%s'\n" "$dest" "$link"
Maybe this should use ln -sf in case dest exists?
> Please note that the attached patch changes the apt pre-install
> invocation from 'Pre-Install-Pkgs' to 'Pre-Invoke'. It seems to me that
> etckeeper doesn't use the package names received on the stdin and I
> think there's no other (substantial) difference between these two hooks.
I don't see a problem with doing that. I had probably planned to use the
package info, and then didn't.
> OTH, this allows the use of darcs w/o the -a option to the record
> command (commit w/o confirmation) and it's useful for examining
> automatic pre-install commits.
I think that etckeeper should do the pre-install commit without confirmation,
unless there´s something significantly different about darcs.
It's fine to be able to configure darcs to confirm or do the commit
interactively.
--
see shy jo
signature.asc
Description: Digital signature
