Bug#507209: mindi-busybox: Doesn't specify a mode to open() call with O_CREAT flag

[James Westby]

Package: mindi-busybox
Version: 1.2.1-3
Severity: normal
Tags: patch
User: [EMAIL PROTECTED]
Usertags: origin-ubuntu jaunty ubuntu-patch

Hi,

open(2) says that you must pass a mode argument when you pass the
O_CREAT flag. archival/gzip.c doesn't do this, and Ubuntu's compiler
catches it.

Attached is a patch to pass the required mode argument. Please consider
applying it.

Thanks,

James

--- mindi-busybox-1.2.1.orig/archival/gzip.c
+++ mindi-busybox-1.2.1/archival/gzip.c
@@ -1232,9 +1232,9 @@
 					/* Open output file */
 #if (__GLIBC__ >= 2) && (__GLIBC_MINOR__ >= 1) && defined O_NOFOLLOW
 					outFileNum =
-						open(path, O_RDWR | O_CREAT | O_EXCL | O_NOFOLLOW);
+						open(path, O_RDWR | O_CREAT | O_EXCL | O_NOFOLLOW, S_IRUSR | S_IWUSR);
 #else
-					outFileNum = open(path, O_RDWR | O_CREAT | O_EXCL);
+					outFileNum = open(path, O_RDWR | O_CREAT | O_EXCL, S_IRUSR | S_IWUSR);
 #endif
 					if (outFileNum < 0) {
 						bb_perror_msg("%s", path);