Package: libxfcegui4-4
Version: 4.4.2-4
Severity: normal
Tags: patch
The following unhelpful error message was traced to code in
libxcfegui4-4:
(xfce4-menu-plugin:3979): libxfcegui4-WARNING **: XfceAppMenuItem: unable to
spawn xfrun4
This message is generated in the function _command_activate_cb, in the file
xfce-apmenuitem.c, in response to any failure from the function
xfce_exec_on_screen. No attempt is made to retrieve a system-level error
message, nor is any attempt made to retrieve an error code from underlying
libraries.
xfce_exec_on_screen takes an error buffer of the type used by the glib
library as its last argument, but _command_activate_cb passes a NULL
pointer, thereby losing any opportunity to recover error information from
the underlying library.
I'm including a patch to make the library include whatever error information
the underlying library provides in its error message. Perhaps next time
I have trouble, I'll be able to do something better than restarting XFCE4
and all my other applications.
-- System Information:
Debian Release: lenny/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: i386 (i686)
Kernel: Linux 2.6.22-2-686 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages libxfcegui4-4 depends on:
ii libatk1.0-0 1.22.0-1 The ATK accessibility toolkit
ii libc6 2.7-15 GNU C Library: Shared libraries
ii libcairo2 1.6.4-6 The Cairo 2D vector graphics libra
ii libglib2.0-0 2.16.6-1 The GLib library of C routines
ii libgtk2.0-0 2.12.1-1 The GTK+ graphical user interface
ii libice6 2:1.0.4-1 X11 Inter-Client Exchange library
ii libpango1.0-0 1.20.5-2 Layout and rendering of internatio
ii libsm6 2:1.0.3-2 X11 Session Management library
ii libstartup-notification0 0.9-1 library for program launch feedbac
ii libx11-6 2:1.1.5-2 X11 client-side library
ii libxfce4util4 4.4.2-3 Utility functions library for Xfce
libxfcegui4-4 recommends no packages.
libxfcegui4-4 suggests no packages.
-- no debconf information
*** xfce-appmenuitem.c.old 2007-11-17 14:29:54.000000000 -0500
--- xfce-appmenuitem.c 2008-11-28 19:21:39.000000000 -0500
***************
*** 184,187 ****
--- 184,188 ----
XfceAppMenuItem *app_menu_item = XFCE_APP_MENU_ITEM(menu_item);
GdkScreen *gscreen;
+ GError *error=NULL;
g_return_if_fail(app_menu_item && app_menu_item->priv->command);
***************
*** 200,207 ****
if(!xfce_exec_on_screen(gscreen, app_menu_item->priv->command_expanded,
app_menu_item->priv->needs_term,
! app_menu_item->priv->snotify, NULL))
{
! g_warning("XfceAppMenuItem: unable to spawn %s\n",
! app_menu_item->priv->command_expanded);
}
}
--- 201,209 ----
if(!xfce_exec_on_screen(gscreen, app_menu_item->priv->command_expanded,
app_menu_item->priv->needs_term,
! app_menu_item->priv->snotify, &error))
{
! g_warning("XfceAppMenuItem: unable to spawn %s: %s\n",
! app_menu_item->priv->command_expanded, error->message);
! g_propagate_error(NULL, error);
}
}
