There's an easy way to fix this:

--- xine-ui-0.99.5+cvs20070914.orig/src/xitk/videowin.c
+++ xine-ui-0.99.5+cvs20070914/src/xitk/videowin.c
@@ -2275,6 +2275,7 @@
 
   if(gGui->ssaver_enabled && (xitk_get_last_keypressed_time() >= (long int) 
gGui->ssaver_timeout)) {
 
+#if 0
 #ifdef HAVE_XTESTEXTENSION
     if(gVw->have_xtest == True) {
       
@@ -2291,6 +2292,7 @@
     }
     else 
 #endif
+#endif
     {
       /* Reset the gnome screensaver. Look up the command in PATH only once to 
save time, */
       /* assuming its location and permission will not change during run time 
of xine-ui. */
--- END ---

but then the feature only works for GNOME users.

Alternately, we can delegate the hackery to xdg-screensaver, which
supports the X server screensaver, xscreensaver, GNOME and KDE:

diff -u xine-ui-0.99.5+cvs20070914/debian/control 
xine-ui-0.99.5+cvs20070914/debian/control
--- xine-ui-0.99.5+cvs20070914/debian/control
+++ xine-ui-0.99.5+cvs20070914/debian/control
@@ -17,6 +17,7 @@
 Package: xine-ui
 Architecture: any
 Depends: ${shlibs:Depends}, libxine1-ffmpeg, libxine1-x | libxine1 (<< 1.1.8-2)
+Recommends: xdg-utils
 Description: the xine video player, user interface
  This is an X11 based GUI for the libxine video player library.
  It provides xine, a skin based media player that can play all the
only in patch2:
unchanged:
--- xine-ui-0.99.5+cvs20070914.orig/src/xitk/panel.c
+++ xine-ui-0.99.5+cvs20070914/src/xitk/panel.c
@@ -363,7 +363,6 @@
  * Update slider thread.
  */
 static void *slider_loop(void *dummy) {
-  int screensaver_timer = 0;
   int status, speed;
   int pos, secs;
   int i = 0;
@@ -450,20 +449,7 @@
        else
          video_window_set_mrl((char *)gGui->mmk.mrl);
        
-       if(!xitk_is_window_iconified(gGui->video_display, gGui->video_window)) {
-         
-         if(gGui->ssaver_timeout) {
-           
-           if(!(i % 2))
-             screensaver_timer++;
-           
-           if(screensaver_timer >= gGui->ssaver_timeout) {
-             screensaver_timer = 0;
-             video_window_reset_ssaver();
-             
-           }
-         }  
-       }
+       
video_window_suspend_ssaver(!xitk_is_window_iconified(gGui->video_display, 
gGui->video_window));
 
        if(gGui->logo_mode == 0) {
          
@@ -503,6 +489,8 @@
            stream_infos_update_infos();
 
        }
+      } else {
+       video_window_suspend_ssaver(0);
       }
     }
     
only in patch2:
unchanged:
--- xine-ui-0.99.5+cvs20070914.orig/src/xitk/videowin.c
+++ xine-ui-0.99.5+cvs20070914/src/xitk/videowin.c
@@ -2271,68 +2271,32 @@
 
 }
 
-void video_window_reset_ssaver(void) {
+void video_window_suspend_ssaver(int do_suspend) {
+  static int was_suspended;
 
-  if(gGui->ssaver_enabled && (xitk_get_last_keypressed_time() >= (long int) 
gGui->ssaver_timeout)) {
+  if(!gGui->ssaver_enabled)
+    do_suspend = 0;
 
-#ifdef HAVE_XTESTEXTENSION
-    if(gVw->have_xtest == True) {
-      
-      gVw->fake_key_cur++;
-      
-      if(gVw->fake_key_cur >= 2)
-       gVw->fake_key_cur = 0;
-
-      XLockDisplay(gGui->video_display);
-      XTestFakeKeyEvent(gGui->video_display, 
gVw->fake_keys[gVw->fake_key_cur], True, CurrentTime);
-      XTestFakeKeyEvent(gGui->video_display, 
gVw->fake_keys[gVw->fake_key_cur], False, CurrentTime);
-      XSync(gGui->video_display, False);
-      XUnlockDisplay(gGui->video_display);
-    }
-    else 
-#endif
-    {
-      /* Reset the gnome screensaver. Look up the command in PATH only once to 
save time, */
-      /* assuming its location and permission will not change during run time 
of xine-ui. */
-      {
-       static char *gssaver_args[] = { "gnome-screensaver-command", "--poke", 
NULL };
-       static char *gssaver_path   = NULL;
-
-       if(!gssaver_path) {
-         char *path = getenv("PATH");
-
-         if(!path)
-           path = "/usr/local/bin:/usr/bin";
-         do {
-           char *p, pbuf[XITK_PATH_MAX + XITK_NAME_MAX + 2];
-           int   plen;
-
-           for(p = path; *path && *path != ':'; path++)
-             ;
-           if(p == path)
-             plen = 1, p = ".";
-           else
-             plen = path - p;
-           plen = snprintf(pbuf, sizeof(pbuf), "%.*s/%s", plen, p, 
gssaver_args[0]);
-           if (plen <= -1 || plen >= sizeof(pbuf))
-             gssaver_path = "";
-           else
-             gssaver_path = (access(pbuf, X_OK)) ? "" : strdup(pbuf);
-         } while(!gssaver_path[0] && *path++);
-       }
-       if(gssaver_path[0] && (fork() == 0)) {
-         execv(gssaver_path, gssaver_args);
-         exit(0);
-       }
-      }
-
-      XLockDisplay(gGui->video_display);
-      XResetScreenSaver(gGui->video_display);
-      XUnlockDisplay(gGui->video_display);
+  if(was_suspended == !do_suspend) {
+    char window_id[30];
+    char *args[] = { "xdg-screensaver", NULL, window_id, NULL };
+
+    args[1] = do_suspend ? "suspend" : "resume";
+    sprintf(window_id, "%lu", (unsigned long)gGui->video_window);
+
+    if(fork() == 0) {
+      execvp(args[0], args);
+      _exit(0);
     }
+
+    was_suspended = do_suspend;
   }
 }
 
+void video_window_reset_ssaver(void) {
+  video_window_suspend_ssaver(1);
+}
+
 void video_window_get_frame_size(int *w, int *h) {
   if(w)
     *w = gVw->frame_width;
only in patch2:
unchanged:
--- xine-ui-0.99.5+cvs20070914.orig/src/xitk/videowin.h
+++ xine-ui-0.99.5+cvs20070914/src/xitk/videowin.h
@@ -83,6 +83,7 @@
 void video_window_update_logo(void);
 void video_window_change_skins(int);
 
+void video_window_suspend_ssaver(int do_suspend);
 void video_window_reset_ssaver(void);
 
 void video_window_get_frame_size(int *w, int *h);
only in patch2:
unchanged:
--- xine-ui-0.99.5+cvs20070914.orig/src/xitk/common.h
+++ xine-ui-0.99.5+cvs20070914/src/xitk/common.h
@@ -332,7 +332,6 @@
   const char               *snapshot_location;
   
   int                       ssaver_enabled;
-  int                       ssaver_timeout;
 
   int                       skip_by_chapter;
 
only in patch2:
unchanged:
--- xine-ui-0.99.5+cvs20070914.orig/src/xitk/event.c
+++ xine-ui-0.99.5+cvs20070914/src/xitk/event.c
@@ -135,9 +135,6 @@
   gGui->skip_by_chapter = cfg->num_value;
   panel_update_nextprev_tips();
 }
-static void ssaver_timeout_cb(void *data, xine_cfg_entry_t *cfg) {
-  gGui->ssaver_timeout = cfg->num_value;
-}
 
 static void visual_anim_cb(void *data, xine_cfg_entry_t *cfg) {
   
@@ -1454,14 +1451,6 @@
                                         snapshot_loc_cb,
                                         CONFIG_NO_DATA);
   
-  gGui->ssaver_timeout =
-    xine_config_register_num (gGui->xine, "gui.screensaver_timeout", 10,
-                             _("Screensaver reset interval (s)"),
-                             _("Time, in seconds, between two faked events to 
keep a screensaver quiet, 0 to disable."),
-                             CONFIG_LEVEL_ADV,
-                             ssaver_timeout_cb,
-                             CONFIG_NO_DATA);
-  
   gGui->skip_by_chapter = 
     xine_config_register_bool (gGui->xine, "gui.skip_by_chapter", 1,
                               _("Chapter hopping"),
--- END ---

Ben.

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to