Zed Pobre wrote: > On Tue, Nov 11, 2008 at 10:31:37PM +0200, Eugene V. Lyubimkin wrote: >> Well, if header _unconditionally_ do typedefs with intXYZ_t, yes, you >> should. No? >> Or remove that typedefs, or move them to some #ifdef too. > > Huh? No, those internal types are required by the remainder of the > code, and cannot be ifdefed out. The typedefs used to create them are > *mandated* by the C99 standard, IIRC, and the only question is where they get > found. W-what? These typedefs don't create intXYZ_t types, they create ULONG, BYTE etc. types.
>> Are you joking? libmodplug's stdafx.h does unchecked typedefs, and qmmp is >> culprit? > > This is absolutely correct. Qmmp failed to make a sane build > environment available, telling libmodplug that files that are > available, weren't. In short, you can't blame libmodplug that qmmp > lied to it about what files it could load. Lied? Huh, what's libmodplug have questioned? :) >> Ok, here is the patch: >> 1st part: advance .pc file to include -DHAVE_STDINT_H in CFLAGS > > No! This is wrong! You cannot force HAVE_STDINT_H without testing > for it first, or it will break on systems that don't actually have > stdint.h! Debian systems (gcc) should on all arches. >> 2nd part: >> [snip] > No! This is what I was trying to tell you was wrong! This won't > include stdint.h if inttypes.h exists, and that will break under > Debian, which provides both. %(. Why should libmodplug require both and what will be broken? -- Eugene V. Lyubimkin aka JackYF Ukrainian C++ developer, Debian APT contributor
signature.asc
Description: OpenPGP digital signature
