Hi,
On Sun, 2008-11-09 at 12:25 +0100, Filippo Giunchedi wrote:
> It seems like that the false positives are all generated by $ inside quotes,
> so
> it might be sufficient to check if preceding single quotes are odd or even.
>
> IOW here is a five minute hack:
[...]
> unless I'm missing something this might work for false positives, same goes
> for $" " of course
Thanks. That's a significant improvement on the original version. :-)
Looking at an earlier set of results, there are still a couple of false
positives but that's 97% less than before and libtool is full of
horrible shell:
libtool_1.5.26-4_i386.deb:possible bashism in ./usr/bin/libtool line 4697
($'...' should be "$(printf '...')"):
libtool_1.5.26-4_i386.deb- reload_objs="$objs$old_deplibs "`$echo
"X$libobjs" | $SP2NL | $Xsed -e '/\.'${libext}$'/d' -e '/\.lib$/d' -e "$lo2o" |
$NL2SP`" $reload_conv_objs" ### testsuite: skip nested quoting test
openc++_2.8-9_i386.deb:possible bashism in ./usr/bin/occ2 line 151 ($'...'
should be "$(printf '...')"):
openc++_2.8-9_i386.deb- , '\''$'\'' => '\''dlr'\''
Adam
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
