Hello Ola and Kir, Thank you for your quick responses to this bug report. I am glad to hear that these bugs have been patched upstream. This will eventually allow us (Ubuntu) to sync vzctl from Debian instead of merging it. I'm looking forward to seeing the 3.0.23 release.
Thanks again, Nathan On Tue, Nov 4, 2008 at 1:41 PM, Ola Lundqvist <[EMAIL PROTECTED]> wrote: > Hi Kir > > Thanks a lot for the comments on this. > > As all this is a part of the 3.0.23 release I will solve this when that > version is released. > > Best regards, > > // Ola > > On Tue, Nov 04, 2008 at 01:11:09PM +0300, Kir Kolyshkin wrote: >> Ola Lundqvist wrote: >> > Hi Nathan >> > >> > Nice to hear from you. Yes this looks like a good patch. >> > Some comments/questions below. >> > >> > On Mon, Nov 03, 2008 at 05:29:18PM -0600, Nathan Handler wrote: >> > ... >> > >> >> In Ubuntu, we've applied the attached patch to achieve the following: >> >> >> >> * etc/bash_completion.d/vzctl.sh.in: >> >> Use "/bin/ls" instead of "ls", so an existing alias for "ls" >> >> does not get used. >> >> >> > >> > This sounds like a good patch. However I find it unlikely that >> > root have any aliases. But it could of course be so. How critical >> > did you find this one? >> > >> >> Someone already reported that bug to OpenVZ bugzilla: >> http://bugzilla.openvz.org/944 >> >> Using /bin/ls instead of ls leads to another problem -- what if 'ls' is >> not in '/bin'? Usually we get around that by having PATH include all >> possible locations for ls, but it obviously doesn't help if you refer to >> it using an absolute path. >> >> The proper solution is to use bash built-in "command". The fix is >> already in the tree, will be available for vzctl-3.0.23: >> http://git.openvz.org/?p=vzctl;a=commit;h=92a5d6f71f41001ef1cc85a8f59b8d0a046a2297 >> >> > >> >> * src/lib/ub.c: Fix typo: s/successefully/successfully/ >> >> >> > >> > Ok good. I assume that this is not a critical thing. >> > >> >> Bug: http://bugzilla.openvz.org/943 >> Fix: >> http://git.openvz.org/?p=vzctl;a=commitdiff;h=7a40b761f1ab080a2868ba77b5b421abcd49ab65 >> >> > >> >> * src/lib/config.c, src/lib/util.c: Explicitly include limits.h >> >> >> > >> > What is the reason for this? I assume that it helps you to compile >> > on some platform but I want to check first. >> > >> >> This is to fix compilation with glibc-2.8 >> >> Bug: https://bugs.gentoo.org/show_bug.cgi?id=228189 >> Bug: http://bugzilla.openvz.org/show_bug.cgi?id=933 >> Fix: >> http://git.openvz.org/?p=vzctl;a=commit;h=77181f0432c7fabd4016bd59451e576c4dec7621 >> >> > >> >> We thought you might be interested in doing the same. >> >> >> > >> > Yes very interesting. However I think you are aware that we are >> > close to release which makes me reluctant to do any changes right >> > now. They will be applied after the release of lenny though. >> > >> > One more question. Have you submitted this upstream, or do you >> > want me to do that? >> > >> Right. >> >> Nathan, please always file the bugs you found upstream, i.e. to >> bugzilla.openvz.org. >> >> >> > > -- > --------------------- Ola Lundqvist --------------------------- > / [EMAIL PROTECTED] Annebergsslingan 37 \ > | [EMAIL PROTECTED] 654 65 KARLSTAD | > | http://inguza.com/ +46 (0)70-332 1551 | > \ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 / > --------------------------------------------------------------- > -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
