Followup-For: Bug #501516
Package: javahelper
Version: 0.16
*** Please type your report below this line ***
The following code is wrong in dh_manifest:
def splitWrite(f, line):
words = line.split()
i = 0
first = True
for w in words:
if i+len(w) > 71:
f.write("\n ")
i = 0
first = True ### this line is wrong
if first:
first = False
else:
f.write(" ")
f.write(w)
i = i + len(w) + 1
f.write("\n")
It should be:
def splitWrite(f, line):
words = line.split()
i = 0
first = True
for w in words:
if i+len(w) > 71:
f.write("\n ")
i = 0
if first:
first = False
else:
f.write(" ")
f.write(w)
i = i + len(w) + 1
f.write("\n")
The reason is that when continuing a line one should have two spaces
at the beginning of the line, one to indicate the line is continued
and the second as a space between list elements.
It strikes me that jh_manifest should really be a program that repairs
manifest files. To this end it should be able to parse "broken"
manifest files and fix them and certainly it should be able to
understand correct manifest files, i.e. ones that have lines that are
already continued on the following line.
There is also an issue with jh_installlibs. That program doesn't
understand manifest files that have broken lines and this means that
jh_installlibs has to be called twice at present: once before
jh_manifest and once after jh_manifest.
regards,
Richard.
-- System Information:
Debian Release: lenny/sid
APT prefers testing
APT policy: (900, 'testing'), (800, 'unstable'), (500, 'stable')
Architecture: i386 (i686)
Kernel: Linux 2.6.18-53.1.13.el5PAE (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages javahelper depends on:
ii debhelper 7.0.15 helper programs for debian/rules
ii devscripts 2.10.35 scripts to make the life of a Debi
ii fastjar 2:0.95-4 Jar creation utility
ii gcj 4:4.3.2-2 The GNU Java compiler
ii python 2.5.2-2 An interactive high-level object-o
ii python-debian 0.1.10 Python modules to work with Debian
ii python-scriptutil 1-1 Python module which provides the f
ii realpath 1.12 Return the canonicalized absolute
ii zip 2.32-1 Archiver for .zip files
javahelper recommends no packages.
javahelper suggests no packages.
-- no debconf information
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
