On Tue, Sep 02, 2008 at 09:25:11PM +0200, Joachim Breitner wrote: > Hi, > > Am Dienstag, den 02.09.2008, 20:52 +0200 schrieb Mike Hommey: > > On Tue, Sep 02, 2008 at 07:41:05PM +0200, Joachim Breitner wrote: > > > Dear Mike, > > > > > > I’m wondering about this bug: > > > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=491100 > > > > > > at first I thought it’s galeon specific, as epiphany does not have this > > > problem, but then I grepped through either’s code and did not find any > > > mention of productSub, so maybe it’s a xulrunner issue? > > > > That might be coming from what data galeon gives the XPCOM glue when > > initializing, or with data that it exposes to the chrome. Have you taken > > a look at epiphany chrome and initialization code ? (don't look for > > productSub, IIRC, this comes from something else) > > thanks for the hint. I found these lines > in ./embed/mozilla/EphyXULAppInfo.cpp: > > ========================== > /* readonly attribute ACString appBuildID; */ > NS_IMETHODIMP > EphyXULAppInfo::GetAppBuildID(nsACString & aAppBuildID) > { > aAppBuildID.Assign (EPHY_BUILD_ID); > return NS_OK; > } > > [..] > > /* readonly attribute ACString platformBuildID; */ > NS_IMETHODIMP > EphyXULAppInfo::GetPlatformBuildID(nsACString & aPlatformBuildID) > { > aPlatformBuildID.Assign (EPHY_BUILD_ID); > return NS_OK; > } > ========================== > > where EPHY_BUILD_ID is set in configure.ac and overridden by a debian > patch, so it’s a good trace... > > But I couldn’t find any similar lines in galeon. The class > EphyXULAppInfo is a subclass of nsIXULAppInfo, but nothing like that > found in galeon either. > > But then, this EphyXULAppInfo is (by use of a CPP macro) only used on > GECKO > 1.9, so maybe there is no parallel code in galeon at all, and > the AppInfo class could just be copied over, with some adjustments. > > Tracking back to where this comes from, the commit message of > http://svn.gnome.org/viewvc/epiphany?view=revision&revision=8228 > namely „Implement nsIXULAppInfo so we get the "Gecko/DATE" part in the > UA right. Use the 2.22.2 release date as the fixed date/build ID.“ > sounds promising. > > So Mike, before I try to create a patch for galeon, do you think this is > the right way to do it?
Sounds like it :) Mike -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
