> I'm not really sure what these variables actually mean and are supposed to > hold, but I find the initalization of GIT_VERSION a bit weird at > debian/ruleset/misc/version_vars.mk:98 > > ifneq ($(strip $(CONFIG_LOCALVERSION_AUTO)),) > GIT_VERSION=$(shell /bin/sh scripts/setlocalversion) > ifneq ($(strip $(GIT_VERSION)),) > GIT_VERSION:=$(GIT_VERSION)-dirty > endif > endif > > It would appear to me that 'setlocaversion' is supposed to set LOCALVERSION, > not GIT_VERSION ? Seemingly it does, since GIT_VERSION contains LOCALVERSION > with -dirty appended, as you would expect from this code. > > The main problem here is that the kernel itself (in utsrelease.h IIRC) thinks > it's just 2.6.22-rc4-g4d33a504-dirty, without that GIT_VERSION crap. Halfway > into the build process, this generates a version mismatch error. I have tried reenabling CONFIG_LOCALVERSION_AUTO once more, and found that it still fails. I highly suspect that the above GIT_VERSION code was needed for older kernel versions, though I can't exactly pinpoint why and when this was changed.
However, since I don't think backwards compatibility is much of an issue here, since user compiling git kernels will usually be compiling recent kernels anyway. Also, I'd rather have this possibly break on older (git) kernels, than knowing it breaks all newer git kernels. I've attached a patch that completely removes all GIT_VERSION stuff, this makes make-kpkg work properly again on my system, with LOCALVERSION_AUTO enabled. Gr. Matthijs -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
