Corey Hickey wrote: > Package: dkimproxy > Version: 1.0.1-6 > Severity: normal > Tags: patch > > Hello, > > I have made several improvements to /etc/init.d/dkimproxy. Many of the > problems I found are interrelated, so please forgive me for not sending > individual patches. I've tested the patch on my system, and so far it seems > to work, but I haven't actually started using dkimproxy yet. If I or anybody > else finds problems, I'll try to revise my patch later. > > Changes: > > * Source /etc/default/dkimproxy so that the user can override relevant > variables used in the init script. > > * Build argument lists differently so that variables can be unset in > /etc/default/default/dkimproxy. This allows the user to specify those > variables in the dkimproxy configuration files. > > * Support variables in /etc/default/dkimproxy to enable/disable > starting the individual dkimproxy daemons. > > * Use "dkimproxy --daemonize" instead of "start-stop-daemon > --background". With the previous version, start-stop-daemon cannot > check exit status, and failures starting dkimproxy are silent with no > way to tell what is causing a failure. > > * Don't exit immediately if dkimproxy.in fails to start, and clean/fix > error checking logic. This was masked by the previous bug. > > * Use 'dkimproxy --pidfile" instead of "start-stop-daemon > --make-pidfile" so the pid is correctly written to the pid file; > otherwise, start-stop-daemon cannot stop/restart dkimproxy. > > * Remove pid files on the "stop" action.
Hi, Your patch is good, however, your configuration file has everything disabled by default. I do NOT want to do things this way, I think it should be set to be run with all the full options as much as possible. So why did you comment out all things in it? Is there any reason? Thomas -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
