No problem.

I am working on a new release to fix the outstanding RC bugs, and will get this fix in as well.

I am going to back out that link-sync patch. It's more trouble than it's worth.

Cheers!

Jon

On Jul 28, 2008, at 3:18 PM, Pablo 'merKur' Kohan wrote:

I just started getting MANY complaints about duplicate e-mail delivery
from IMAP users.  Upon investigation, it turns out that Dan Bernstein
doesn't obey his own rules about manipulating Maildirs.
I'm having the same issues one of my servers.
Thanks for diagnosing it ! It drove my users crazy.

One comment though. While checking this, I found out that it's not in
the original qmail source, but it comes from one of the applied patches:
Frank Denis's qmail-link-sync
http://www.thedjbway.org/qmail/patches/qmail-1.03.link-sync.patch


Alternatively, you can just ignore a failure to open.  I.e. replace

if ((fd = open(fnnewtph, O_RDONLY)) < 0 ||
    fsync(fd) < 0 || close(fd) < 0) goto fail;

by

if ((fd = open(fnnewtph, O_RDONLY)) >= 0)
 {
  fsync(fd);
  close(fd);
 }
This works very well, and is much less intrusive than Guenter's syncdir
patch (which actually fsyncs the directory, as you mentioned).

Jon, could you please include the fix above in future qmail-src
releases ?

Thanks,
Pablo







--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to