Olaf Meeuwissen <[EMAIL PROTECTED]> writes: > Brad Sawatzky <[EMAIL PROTECTED]> writes: > >> On Fri, 27 Jun 2008, Olaf Meeuwissen wrote: >> >>> Here is the scoop on the epson4490-fixup.patch: >>> >>> | - Fixed an off by one error in the original filter_resolution() function. >>> >>> The array has the size in its first element (see the last line of the >>> patch), as per requirement for SANE_CONSTRAINT_WORD_LIST. Instead of >>> fixing an off by one error, you introduce one. >> >> I don't think so... but the confusion is understandable. >> s->hw->resolution_list[] has the length in element 0, but >> s->hw->res_list[] does not. >> The length of s->hw->res_list[] is stored in s->hw->res_list_size. >> The for() loop was iterating over s->hw->res_list[]. > > I'll have a second look at that.
Just did that. Seems you are right ... for the iscan-2.10.0 code. The code for iscan-2.11.0 contains a rewritten implementation of that function that is not affected by this off by one error. Hope this helps, -- Olaf Meeuwissen FLOSS Engineer -- AVASYS Corporation FSF Associate Member #1962 sign up at http://member.fsf.org/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
