On Tue, 1 Jul 2008, Raphael Hertzog wrote:

On Tue, 01 Jul 2008, Guillem Jover wrote:
While I realize that using dpkg-divert on conffiles is an uncommon
practice, the current behavior is clearly wrong.

I've attached a simple git patch against current head that fixes this.

Thanks for the patch! There's a problem with it though, namenodetouse
has as a side effect to activate a file trigger. I'll probably be moving
the side effect outside that function before applying this patch.

We still have to activate the file trigger if we're effectively modifying
the configuration file (i.e. in all cases except if the user decides to
keep the old file IMO).

So it could be argued that it's right to activate the trigger. After all,
even if the user choose to keep the old configuration file, he might have
merged some of the changes by hand (using the spawned shell).

Do I miss something here?

I think the point is that namenodetouse is already being called when unpacking the archive, and thus triggers have already been activated on the new filename.

        -Tim Abbott



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to