Hi Austin,
Austin Clements wrote:
The implementation of the dbus-hal suspend method in the
/usr/share/acpi-support/suspendorhibernate script is incorrect. I've
attached a patch which fixes a number of issues with the
implementation:
* Currently, it calls the DBUS wrong method and thus reliably fails.
Ah, that means I read the docs incorrectly. Thanks for correcting me!
* stderr was dup'd on to stdout using "2&>1" instead of "2>&1", which
was passing '2' as an additional argument and redirecting the
output to a file called '1' instead of the intended effect.
Youch, that's a nasty one!
* The current check for a DBUS error is fragile, since it uses 'grep
-v' instead of negating the whole condition (that is, currently it
checks if all output lines are not DBUS errors instead of checking
that no output lines are DBUS errors, though these appear to be
equivalent in the current implementation of dbus-send).
Sounds more robust indeed.
I also made the latter two fixes to the dbus-pm method, though I can't
vouch for the correctness of the method being called in that case.
Thanks very much for fixing this up. I'll include the fixes in the next
upload.
Cheers,
Bart
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
