Hi, This is concerning the addition of quilt.el to Debian. See:
http://bugs.debian.org/345988 I wonder if emacs-goodies-el is really the best place for this add-on. How would quilt users even know where to find it? I think that the best place for it is within the quilt package itself. However, I do realise that there is a large overhead in adding an elisp file to a package (load-path, byte-compilation, code initilisation) and it would be less overall work to add it to emacs-goodies-el. Thoughts? As an aside, I looked at the code. It is in general okay, but far from checkdoc clean. Open it in Emacs and run: M-x checkdoc to see where. Also, it defines `C-cc' keys against coding conventions. From the elisp manual: : D.2 Key Binding Conventions : =========================== : : * Please do not define `C-c LETTER' as a key in Lisp programs. : Sequences consisting of `C-c' and a letter (either upper or lower : case) are reserved for users; they are the *only* sequences : reserved for users, so do not block them. : : Changing all the Emacs major modes to respect this convention was a : lot of work; abandoning this convention would make that work go to : waste, and inconvenience users. Please comply with it. : : * Sequences consisting of `C-c' followed by a control character or a : digit are reserved for major modes. I suggest the prefix `C-cC-c' instead. It doesn't byte-compile cleanly: : In quilt-editable: : quilt.el:92:22:Warning: reference to free variable `quilt-edit-top-only' : : In quilt-update-modeline: : quilt.el:109:9:Warning: `make-variable-buffer-local' should be called at : toplevel : : In end of data: : quilt.el:313:1:Warning: the following functions are not known to be : defined: to-alist, editable, revert, revert-list This very last one is more important. The code has many embedded `defun' function definitions, which won't byte-compile, and which will pollute emacs once they get evaluated. I would prefix them all with "quilt-" and place them at top level (i.e. not embbeded in code). All of these issues can be easily addressed, and should be prior to inclusion in Debian. Thanks, -- Peter S. Galbraith, Debian Developer <[EMAIL PROTECTED]> http://people.debian.org/~psg GPG key 1024/D2A913A1 - 97CE 866F F579 96EE 6E68 8170 35FF 799E -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
