Hi, On Wed, May 21, 2008 at 05:40:04PM +0700, Ivan Shmakov wrote: > Please consider the following patch. > > $ diff -u \ > <(zcat /usr/share/doc/collectd/examples/collectd2html.pl.gz) \ > collectd2html.pl
I'm quite surprised to get a patch for that script. It has never been ported to version 4 of collectd and should not work at all right now. I was actually going to remove it entirely from the package but must have forgotten about it. Did you update the script to work with version 4? If so, please provide those patches as well. > GetOptions ( > "host=s" => \$HOST, > - "data-dir=s" => \$DIR > + "data-dir=s" => \$DIR, > + "image-format=s" => \$IMG_FMT > ); [...] > +my $svg_p = ($IMG_FMT eq "SVG"); > +my $IMG_SFX = $svg_p ? ".svg" : ".png"; Currently, all image formats supported by rrdtool (svg, ps and pdf iirc) do require special handling in the HTML output (e.g. just include a link for the ps and pdf formats) - could you please extent your patch to handle that as well? TIA. Cheers, Sebastian -- Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/ Those who would give up Essential Liberty to purchase a little Temporary Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin
signature.asc
Description: Digital signature
