Bug#481183: crippled with DRM anti-features

[Robert Millan]

Package: libpoppler2
Version: 0.6.4-1
Severity: important
Tags: patch

This library appears to be crippled with DRM anti-features.  Here's a patch
to remove them.  Please apply it so that our users can exercise the fair use
rights they're entitled to.

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.18-6-amd64 (SMP w/2 CPU cores)
Locale: LANG=ca_AD.UTF-8, LC_CTYPE=ca_AD.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages libpoppler2 depends on:
ii  libc6                  2.7-10            GNU C Library: Shared libraries
ii  libfontconfig1         2.5.0-2           generic font configuration library
ii  libfreetype6           2.3.5-1+b1        FreeType 2 font engine, shared lib
ii  libgcc1                1:4.3.0-4         GCC support library
ii  libjpeg62              6b-14             The Independent JPEG Group's JPEG 
ii  libstdc++6             4.3.0-4           The GNU Standard C++ Library v3
ii  libxml2                2.6.32.dfsg-2     GNOME XML library
ii  zlib1g                 1:1.2.3.3.dfsg-12 compression library - runtime

libpoppler2 recommends no packages.

-- no debconf information

diff -ur poppler-0.6.4.old/poppler/XRef.cc poppler-0.6.4/poppler/XRef.cc
--- poppler-0.6.4.old/poppler/XRef.cc	2008-01-21 21:00:59.000000000 +0100
+++ poppler-0.6.4/poppler/XRef.cc	2008-05-14 13:55:46.000000000 +0200
@@ -823,45 +823,38 @@
 }
 
 GBool XRef::okToPrint(GBool ignoreOwnerPW) {
-  return (!ignoreOwnerPW && ownerPasswordOk) || (permFlags & permPrint);
+  return gTrue;
 }
 
 // we can print at high res if we are only doing security handler revision
 // 2 (and we are allowed to print at all), or with security handler rev
 // 3 and we are allowed to print, and bit 12 is set.
 GBool XRef::okToPrintHighRes(GBool ignoreOwnerPW) {
-  if (2 == encRevision) {
-    return (okToPrint(ignoreOwnerPW));
-  } else if (encRevision >= 3) {
-    return (okToPrint(ignoreOwnerPW) && (permFlags & permHighResPrint));
-  } else {
-    // something weird - unknown security handler version
-    return gFalse;
-  }
+  return gTrue;
 }
 
 GBool XRef::okToChange(GBool ignoreOwnerPW) {
-  return (!ignoreOwnerPW && ownerPasswordOk) || (permFlags & permChange);
+  return gTrue;
 }
 
 GBool XRef::okToCopy(GBool ignoreOwnerPW) {
-  return (!ignoreOwnerPW && ownerPasswordOk) || (permFlags & permCopy);
+  return gTrue;
 }
 
 GBool XRef::okToAddNotes(GBool ignoreOwnerPW) {
-  return (!ignoreOwnerPW && ownerPasswordOk) || (permFlags & permNotes);
+  return gTrue;
 }
 
 GBool XRef::okToFillForm(GBool ignoreOwnerPW) {
-  return (!ignoreOwnerPW && ownerPasswordOk) || (permFlags & permFillForm);
+  return gTrue;
 }
 
 GBool XRef::okToAccessibility(GBool ignoreOwnerPW) {
-  return (!ignoreOwnerPW && ownerPasswordOk) || (permFlags & permAccessibility);
+  return gTrue;
 }
 
 GBool XRef::okToAssemble(GBool ignoreOwnerPW) {
-  return (!ignoreOwnerPW && ownerPasswordOk) || (permFlags & permAssemble);
+  return gTrue;
 }
 
 Object *XRef::fetch(int num, int gen, Object *obj) {