severity 475475 minor found 475475 1.11-1 thanks On Thursday 10 April 2008, Micah Cowan wrote: > Raphael Geissert wrote: > > Package: wget > > Version: 1.11.1-1 > > Severity: important > > > > A few days ago I updated to the latest version of the package and it > > silently broke some data updating scripts. > > > > wget is executed like this: > >> wget -N -O foo.db.new http://source.tld/foo.db > > > > And since the latest version it throws the next message: > >> Cannot specify -r, -p or -N if -O is given. > >> Usage: wget [OPTION]... [URL]... > > > > But it is only sent to stdout, which prevented me from noticing the > > failure via the cronjob emails. > > > > It worked just fine in 1.11-1 and previous, > > No, the change was introduced in 1.11. You probably mean 1.10.2.
I just realised I upgraded from 1.10.2 to 1.11.1, so yes, it 'worked' until 1.10.2. > > But, in fact, it never "worked", it was just silently _allowed_. > Timestamping was never supported for -O. > > > and I see this new 'behaviour' > > broken. There should be no reason why -O and -N can't both be used at the > > same time. > > Because -O doesn't mean "use this filename", it means "redirect output > to this file", rather like the shell does (see the manpage). The thing is that it can be interpreted in different ways, maybe it could be more explicit. > > This means the local timestamp will _always_ be "now", regardless of the > last time you'd previously run Wget (and the local file will also > already be empty: it's a redirection). So timestamping is utterly useless. > > However, a case could be made that it's better to issue a warning that > the combination is nonsensical, rather than exit (on the other hand, the > error is a much better way to make it clear that -N and -O do not do > what the user expected it to). IMHO it should continue working as usually, but throwing a warning to stderr so scripts can be fixed. > Also, the message should clearly go to > stderr, not to stdout. :) Cheers, -- Atomo64 - Raphael Please avoid sending me Word, PowerPoint or Excel attachments. See http://www.gnu.org/philosophy/no-word-attachments.html
signature.asc
Description: This is a digitally signed message part.
