On Wed, May 18, 2005 at 12:44:44AM +0300, Jari Aalto wrote:
> | On Sat, May 14, 2005 at 06:44:16PM +0300, Jari Aalto wrote:
> | > SUGGESTION
> | > Please display a message that dropbear is disabled (like openSSH gives),
> | > something like this in case user tries "reload", "strart" etc.
> | > Start ignored. Dropbear is not enabled in /etc/default/dropbear,
> | Hi Jari, I'm not sure that's necessary. Normally sysv init scripts
> | print along a line 'Starting foo daemon... done' when starting a
> | service. If it doesn't print anything, doesn't this already tell that
> | starting the service didn't work out?
> How will silence indicate an error? User needs to be notified in case
> of errors like this. Just like the "Starting..." message is followed by:
Hi, see, I would've answered 'yes' to my question, I'm not yet convinced
that all users think like you. Please see
http://www.debian.org/doc/debian-policy/ch-opersys.html#s-sysvinit
http://refspecs.freestandards.org/LSB_2.1.0/LSB-Core-generic/LSB-Core-generic.html#INISCRPTACT
and the sysvinit documentation.
> Please add error checking and error indication message.
Anyway, Gerrit.
Index: debian/dropbear.init
===================================================================
RCS file: /cvs/dropbear/debian/dropbear.init,v
retrieving revision 1.2
diff -u -r1.2 dropbear.init
--- debian/dropbear.init 20 May 2004 15:47:15 -0000 1.2
+++ debian/dropbear.init 21 May 2005 14:21:56 -0000
@@ -14,10 +14,12 @@
set -e
+cancel() { echo "$1" >&2; exit 0; };
test ! -r /etc/default/dropbear || . /etc/default/dropbear
-test "$NO_START" = "0" || exit 0
-test -x "$DAEMON" || exit 0
-test ! -h /var/service/dropbear || exit 0
+test "$NO_START" = "0" || cancel 'NO_START is not set to zero.'
+test -x "$DAEMON" || cancel "$DAEMON does not exist or is not executable."
+test ! -h /var/service/dropbear || \
+ cancel '/var/service/dropbear exists, service is controlled through runit.'
test -z "$DROPBEAR_BANNER" || \
DROPBEAR_EXTRA_ARGS="$DROPBEAR_EXTRA_ARGS -b $DROPBEAR_BANNER"
