Manoj Srivastava wrote: > The issue is that we need to convert relative links to absolute > ones for atom and rss feeds -- but there are two types of > relative links. The first kind, relative to the current > document ( href="some/path") is handled correctly. The second > kind of relative url is is relative to the http server > base (href="/semi-abs/path"), and that broke. > > It broke because we just prepended the url of the current > document to the href (http://host/path/to/this-doc/ + link), > which gave us, in the first place: > http://host/path/to/this-doc/some/path [correct], and > http://host/path/to/this-doc//semi-abs/path [wrong] > > The fix is to calculate the base for the http server (the base of > the wiki does not help, since the base of the wiki can be > different from the base of the http server -- I have, for example, > "url => http://host.name.mine/blog/manoj/"), and prepend that to > the relative references that start with a /.
How does a relative url start with / ? That would be broken anyway, so can't this be simplified to just adding [^\/] to the url regexp? -- see shy jo
signature.asc
Description: Digital signature