Hi Vincent
I'm not fully sure but I think your patch was broken...
applying patch 09sesman_sig_handling to ./ ...patch: **** malformed patch at
line 22: + LOG_DBG("g_waitchild() [%d] No more children", g_getpid())
failed.
make: *** [patch-stamp] Fel 1
I applied it manually and also added a ';' character. I'll see if that helps.
// Ola
On Wed, Mar 26, 2008 at 08:39:39PM +0100, Vincent Bernat wrote:
> OoO Vers la fin de l'après-midi du samedi 22 mars 2008, vers 16:32, Ola
> Lundqvist <[EMAIL PROTECTED]> disait:
>
> > With the -DDEBUG and 08 and 09 patch sesman crashes. So I tried once
> > without any
> > extra patches. Just the -DDEBUG added.
> [...]
> > And with the 09 patch I get the following (with -DDEBUG):
>
> > lapilli:~# tail -f /var/log/sesman.log
> > [20080322-16:29:27] [DEBUG] sesman received SIGTERM
> > [20080322-16:29:27] [INFO ] shutting down sesman 1
> > [20080322-16:29:27] [DEBUG] - getting signal 15 pid 3566
> > [20080322-16:29:27] [DEBUG] lock_chain_acquire()
> > [20080322-16:29:27] [DEBUG] lock_chain_release()
> > [20080322-16:29:27] [DEBUG] calling sigwait()
> > [20080322-16:29:43] [INFO ] starting signal handling thread...
> > [20080322-16:29:43] [INFO ] signal handler thread started successfully
> > [20080322-16:29:43] [ERROR] error opening pid file: No such file or
> > directory
> > [20080322-16:29:43] [CORE ] shutting down log subsystem...
>
> I don't really understand how you get this error with my patch. In
> sesman.c, there is a first check that the PID file exists and if it
> exists, there is an attempt to open it. But you get the message because
> the PID file does not exist. Maybe there is a race condition but this
> unrelated to the patch 09.
>
> Can you try from a fresh ground? apt-get source xrdp, add patch 8 and
> patch 9, compile with debug. And BTW, instead of the precedent patch 9,
> can you try this one instead? If you get several "Child xxx is dead"
> before "No more children", then we hit a bug in the original code.
>
>
> Thanks !
> --
> HIGH EXPLOSIVES AND SCHOOL DON'T MIX
> HIGH EXPLOSIVES AND SCHOOL DON'T MIX
> HIGH EXPLOSIVES AND SCHOOL DON'T MIX
> -+- Bart Simpson on chalkboard in episode 8F03
--
--- Ola Lundqvist systemkonsult --- M Sc in IT Engineering ----
/ [EMAIL PROTECTED] Annebergsslingan 37 \
| [EMAIL PROTECTED] 654 65 KARLSTAD |
| http://opalsys.net/ Mobile: +46 (0)70-332 1551 |
\ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 /
---------------------------------------------------------------
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
