On Tue, 25 Mar 2008, Joey Hess wrote: > > Part 3: Correct diagnostic text when symbol cannot be found, new: > > > > Index: src/mklibs.py > > =================================================================== > > --- src/mklibs.py (revision 51573) > > +++ src/mklibs.py (working copy) > > @@ -469,7 +493,7 @@ > > for name in needed_symbols: > > if not name in symbol_provider: > > if not needed_symbols[name].weak: > > - raise "No library provides non-weak %s" % symbol > > + raise "No library provides non-weak %s" % name > > My python is not particularly good, but I don't see where symbol is > defined. Only way it could be set is in one of the loops above, but > that would have no relation to the name.
Yes, that's the bug I'm fixing. In the unmodified mklibs, symbol comes from a previous loop and so the diagnostic has no relation to the symbol that isn't found, which naturally confuses any attempt to debug problems hitting this exception. With my patch, instead there's a diagnostic with the correct name. -- Joseph S. Myers [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
