Package: cron-apt
Version: 0.4.14
Followup-For: Bug #467616
Tags: patch
(Butting in on cstandbridge's wishlist, since I'd just noticed it
myself)
Ola Lundqvist wrote:
> Thanks for the report. I can not recall either adding nor removing
> any logrotate config for this package.
>
> Which file is it that you want rotated?
cron-apt creates /var/log/cron-apt/log; on my own Stable desktop
system, with a default config, that file has reached 269K. Not
exactly a DoS, but it's not how logs are meant to work, and it does
seem to be a packaging error.
The src/Makefile has the following lines:
# Logrotate
mkdir -p $(DESTDIR)$(LOGROTDIR)
cp src/logrotate $(DESTDIR)$(LOGROTDIR)/cron-apt
But that gives an error:
cp: cannot stat `src/logrotate': No such file or directory
The file exists, it's just looking in the wrong place; take out the
"src/" and everything works. Minimalist patch attached.
CAVEATS: I Am Not A Programmer, and this is almost certainly not the
"right" way to fix cron-apt. I suspect the "right" way would
involve activating the "#dh_installlogrotate" line in the rules
file, but then you'd need a logrotate file in debian/, not src/.
> root.adm file ownership could be managed, but it is not trivial.
That would presumably require the Makefile process that creates the
logdir also to do something like
install -g adm -m 0640 /dev/null $(DESTDIR)$(LOGDIR)/log
which looks pretty trivial to me, but my patch only takes it as far
as fixing the build error.
--
JBR
Ankh kak! (Ancient Egyptian blessing)
diff -ur cron-apt-0.6.4.old/src/Makefile cron-apt-0.6.4.new/src/Makefile
--- cron-apt-0.6.4.old/src/Makefile 2007-08-02 15:34:13.000000000 +0100
+++ cron-apt-0.6.4.new/src/Makefile 2008-03-09 17:02:31.000000000 +0000
@@ -19,4 +19,4 @@
install -m644 functions $(DESTDIR)$(SHAREDIR)/functions
# Logrotate
mkdir -p $(DESTDIR)$(LOGROTDIR)
- cp src/logrotate $(DESTDIR)$(LOGROTDIR)/cron-apt
+ cp logrotate $(DESTDIR)$(LOGROTDIR)/cron-apt
