Package: kde-style-qtcurve Severity: important Version: 1.1-1 User: [EMAIL PROTECTED] Usertags: qa-doublebuild Tags: patch
Hi While trying to look into http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=462001 I noticed that your package fails to build twice in a row. CMake is in general not good for in-tree build - and haven't got a make distclean that works. CMake is in generally used for out of tree builds. If you are busy, feel free to ask for NMUs (As this is a release goal, I might do it within the next month anyway if not asked) See the following patch: (also attached) diff -u kde-style-qtcurve-0.55.2/debian/rules kde-style-qtcurve-0.55.2/debian/rules --- kde-style-qtcurve-0.55.2/debian/rules +++ kde-style-qtcurve-0.55.2/debian/rules @@ -24,24 +24,19 @@ CFLAGS += -O2 endif -config.status: CMakeLists.txt config.h.cmake +builddir/config.h: dh_testdir # Add here commands to configure the package. -ifneq "$(wildcard /usr/share/misc/config.sub)" "" - cp -f /usr/share/misc/config.sub config.sub -endif -ifneq "$(wildcard /usr/share/misc/config.guess)" "" - cp -f /usr/share/misc/config.guess config.guess -endif - cmake . + mkdir -p builddir + cd builddir && cmake .. build: build-stamp -build-stamp: config.status +build-stamp: builddir/config.h dh_testdir # Add here commands to compile the package. - $(MAKE) + cd builddir && $(MAKE) #docbook-to-man debian/kde-style-qtcurve.sgml > kde-style-qtcurve.1 touch $@ @@ -52,8 +47,7 @@ rm -f build-stamp # Add here commands to clean up after the build process. - -$(MAKE) distclean - rm -f config.sub config.guess + rm -rf builddir dh_clean @@ -64,7 +58,7 @@ dh_installdirs # Add here commands to install the package into debian/kde-style-qtcurve. - $(MAKE) DESTDIR=$(CURDIR)/debian/kde-style-qtcurve install + cd builddir && $(MAKE) DESTDIR=$(CURDIR)/debian/kde-style-qtcurve install # Build architecture-independent files here. -- How can I load a device from MkLinux 3.2.8 and from the options inside Flash? From the control tools menu within MS-DOS NT you never have to digit on a mailer for removing a hard disk.
diff -u kde-style-qtcurve-0.55.2/debian/rules kde-style-qtcurve-0.55.2/debian/rules --- kde-style-qtcurve-0.55.2/debian/rules +++ kde-style-qtcurve-0.55.2/debian/rules @@ -24,24 +24,19 @@ CFLAGS += -O2 endif -config.status: CMakeLists.txt config.h.cmake +builddir/config.h: dh_testdir # Add here commands to configure the package. -ifneq "$(wildcard /usr/share/misc/config.sub)" "" - cp -f /usr/share/misc/config.sub config.sub -endif -ifneq "$(wildcard /usr/share/misc/config.guess)" "" - cp -f /usr/share/misc/config.guess config.guess -endif - cmake . + mkdir -p builddir + cd builddir && cmake .. build: build-stamp -build-stamp: config.status +build-stamp: builddir/config.h dh_testdir # Add here commands to compile the package. - $(MAKE) + cd builddir && $(MAKE) #docbook-to-man debian/kde-style-qtcurve.sgml > kde-style-qtcurve.1 touch $@ @@ -52,8 +47,7 @@ rm -f build-stamp # Add here commands to clean up after the build process. - -$(MAKE) distclean - rm -f config.sub config.guess + rm -rf builddir dh_clean @@ -64,7 +58,7 @@ dh_installdirs # Add here commands to install the package into debian/kde-style-qtcurve. - $(MAKE) DESTDIR=$(CURDIR)/debian/kde-style-qtcurve install + cd builddir && $(MAKE) DESTDIR=$(CURDIR)/debian/kde-style-qtcurve install # Build architecture-independent files here.
signature.asc
Description: This is a digitally signed message part.
