At Tue, 26 Feb 2008 21:22:39 +1100,
Peter Chubb wrote:
>
> >>>>> "satoru" == satoru takeuchi <[EMAIL PROTECTED]> writes:
>
> satoru> Hi, At Mon, 25 Feb 2008 10:41:55 +1100, Peter Chubb wrote: ...
> >> I'm using quilt-el with xemacs. After editing for a while, I always
> >> see `Wrong type argument: stringp, nil' when doing push or pop
> >> operations. Quilt-push and quilt-pop operations are pretty slow,
> >> too.
>
> satoru> Does it happen on another quilt repository, or on just one?
> satoru> And what in case of issuing other commands like quilt-top?
>
> It happens with all the quilt repositories I have.
>
> It happens with quilt-push, quilt-pop, quilt-goto, and quilt-push-all
> but not with quilt-applied, quilt-files or quilt-top. All the
> commands that have to update buffer status --- the problem is in
> quilt-revert.
Thank you for your hint and patch!
I suspect there are two problems.
- `Wrong type argument: stringp, nil' message is shown.
- quilt-revert is pretty slow.
The former happens if default-directory is nil and can be fixed
by the attached patch. Your patch can bypass this bug indirectly.
The latter case is complecated. quilt-revert still slow on my
environment even if there are several buffers. Does the latter
case fixed on your case by your patch?
I'm trying to optimization now. However I don't know whether it's
possible or not.
BTW, I'm going to make the new package including the attached
patch and your optimizatinon patch (and plus alpha). Please test
it then and CMIIW.
Regards,
Satoru
Index: quilt-el/quilt.el
===================================================================
--- quilt-el.orig/quilt.el 2008-02-26 23:57:45.000000000 +0900
+++ quilt-el/quilt.el 2008-02-26 23:58:44.000000000 +0900
@@ -36,7 +36,8 @@
(quilt-find-dir (if fn fn
(let ((fn2 (quilt-buffer-file-name-safe)))
(if fn2 fn2
- (expand-file-name default-directory))))))
+ (if default-directory
+ (expand-file-name default-directory)))))))
(defun quilt-drop-dir (fn)
(let ((d (quilt-find-dir fn)))
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
