Hi,
Thanks for the patch. Just a couple of quick comments / queries (feel
free to ignore them; well, other than the B-D-I one :)
Cheers,
Adam
* Please handle Build-Depends-Indep as well as Build-Depends.
*
=item B<-m> B<--print-maintainer>
Print the maintainer information for each package. This feature
is currently experimental, because it prints wrong information
under some circumstances.
Which circumstances? You're outputting the value of the Maintainer
field, so (other than possibly anchoring the regex - i.e. /^Maintainer:
(.*)/) it should always produce the correct result.
* Would it be possible to combine the two grep-dctrl calls in
$builddeps = `$dctrl -F Package $depending_package -s Build-Depends
$source_file`;
if ( $builddeps =~ /\s$package[\s,]{1}/ ) {
$count += 1;
if ($opt_maintainer) {
$_ = `$dctrl -F Package $depending_package -s
Maintainer $source_file`;
in to a single call? The maintainer information could always then be discarded
if it's not being output.
*
if ( /Package: .*$/ ) {
/Package: (.*)$/;
my $depending_package = $1;
is equivalent to
if ( m/^Package: (.*)$ ) {
my $depending_package = $1;
which avoids the risk of you forgetting to change one of the expressions
in sync with the other.
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
