Mark Brown <[EMAIL PROTECTED]> writes:
> On Wed, May 04, 2005 at 07:37:09PM +0200, Goswin Brederlow wrote:
>
>> attached is a minor patch to build x86info on amd64 as 32bit code (due
>> to the i386 asm). Please consider fixing this for sarge as well as
>> sid.
>
> It's *very* late in the game (ie, post freeze) to be doing sarge
> targetted fixes. Any sarge upload will be based off the latest unstable
> package since the only change in there is a spelling fix.
Since the only change is to amd64 and fixes an FTBFS there I hope the
release team will let this in. If not the package will just not be
available on amd64.
>> +x86info (1.13-1.0.0.1.pure64) unstable; urgency=low
>> +
>> + * NMU - add support to build 32bit code on amd64
>
> Just to be clear, please *do not* upload this without talking to me
> again first (I guess you don't intend to do so, but I'd rather be overly
> clear than be surprised).
>
>> +DEB_BUILD_ARCH=$(shell dpkg-architecture -qDEB_BUILD_ARCH)
>> +#ifeq $(DEB_BUILD_ARCH),amd64
>> +CC=gcc-3.4
>> +export CC
>> +#endif
>
> This looks suspicious to me... I would have expected to be doing
> something like adding an -m32 to CFLAGS with the default compiler rather
> than invoking a specific GCC version with apparently defualt options but
> I've never used a hammer system, I'm just generalising from my
> experience with things like SPARC.
Well, the problem is this:
gcc-3.3 in debian can not compile for the other bitness, i.e. on i386
-m64 fails and on amd64 -m32 fails.
gcc-3.4 has been build as biarch compiler on both i386 and amd64. This
is already used in kernel-image-2.6.8-amd64 to compile in on i386.
Also the x86info Makefile tests for the -m32 switch and already adds
it automatically. The compile with gcc-3.3 then fails due to missing
support in Debian. So switching to gcc-3.4 for amd64 is all that is
needed.
> There were also some upstream things checked in recently for AMD64
> support - I'll check what they were before I do anything with this.
I guess that would be the test for -m32 in the Makefile. :)
> --
> "You grabbed my hand and we fell into it, like a daydream - or a fever."
MfG
Goswin
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
