On 16/01/2008, Debian Bug Tracking System <[EMAIL PROTECTED]> wrote:
> Please do not reply to the address at the top of this message,
> unless you wish to report a problem with the Bug-tracking system.
I have made a simple package out of the upstream source and found that
the "454221: tilda: doesn't close tabs on exit" bug was still present.
Then I took the upstream CVS and found other two bugs were fixed and I
extracted the nice patches.
0001-Focus-stealing-prevention-fix.patch
0002-BUGFIX-Prevent-copy-and-paste-from-propagating-eve.patch
Please apply them to the 0.9.5-1 binary.
Thanks
--
Regards,
EddyP
=============================================
"Imagination is more important than knowledge" A.Einstein
From 1e0bd92f5d9e35b66087002bcdd1d6bd585b0335 Mon Sep 17 00:00:00 2001
From: irasnyd <irasnyd>
Date: Wed, 16 Jan 2008 04:27:48 +0000
Subject: [PATCH] Focus stealing prevention fix
This simple, one line fix appears to fix all of the focus stealing
problems that have been plaguing us. I tested this in GNOME with Metacity,
GNOME with Openbox, and KDE with kwin. All worked beautifully.
Signed-off-by: Ira W. Snyder <[EMAIL PROTECTED]>
diff --git a/src/key_grabber.c b/src/key_grabber.c
index f79d6c6..fb67a04 100644
--- a/src/key_grabber.c
+++ b/src/key_grabber.c
@@ -154,8 +154,11 @@ void pull (struct tilda_window_ *tw, enum pull_state state)
* focus stealing prevention that is present in openbox and others.
*
* WARNING: Don't move this up to the top, where the window is shown, or you
- * will cause some strange glitches. :) */
- gtk_window_present (GTK_WINDOW(tw->window));
+ * will cause some strange glitches. :)
+ *
+ * NOTE: Using gtk_window_present_with_time() keeps away the nasty focus-stealing-prevention
+ * in metacity and others. DO NOT make this gtk_window_present()! */
+ gtk_window_present_with_time (GTK_WINDOW(tw->window), tomboy_keybinder_get_current_event_time());
#if DEBUG
/* The window is definitely in the pulled down state now */
--
1.5.3.7
From a17f374025234c1866a6a829341c23607f321897 Mon Sep 17 00:00:00 2001
From: irasnyd <irasnyd>
Date: Thu, 13 Dec 2007 21:31:25 +0000
Subject: [PATCH] [BUGFIX] Prevent copy and paste from propagating events
The copy and paste, implemented by ccopy() and cpaste(), failed to
stop the propagation of the events after copying the text. This caused a
Ctrl+C to be sent to the shell, killing any running program.
Fixes Bug #173102 in Ubuntu's tilda bugs.
Fixes Bug #162024 in Ubuntu's tilda bugs.
Signed-off-by: Ira W. Snyder <[EMAIL PROTECTED]>
diff --git a/src/tilda_window.c b/src/tilda_window.c
index c6ccfb9..7cc2d7d 100644
--- a/src/tilda_window.c
+++ b/src/tilda_window.c
@@ -216,7 +216,7 @@ static gboolean goto_tab_8 (tilda_window *tw) { return goto_tab_generic (tw, 8)
static gboolean goto_tab_9 (tilda_window *tw) { return goto_tab_generic (tw, 9); }
static gboolean goto_tab_10 (tilda_window *tw) { return goto_tab_generic (tw, 10); }
-static void ccopy (tilda_window *tw)
+static gint ccopy (tilda_window *tw)
{
DEBUG_FUNCTION ("ccopy");
DEBUG_ASSERT (tw != NULL);
@@ -229,9 +229,12 @@ static void ccopy (tilda_window *tw)
current_page = gtk_notebook_get_nth_page (GTK_NOTEBOOK (tw->notebook), pos);
list = gtk_container_get_children (GTK_CONTAINER(current_page));
vte_terminal_copy_clipboard (VTE_TERMINAL(list->data));
+
+ /* Stop the event's propagation */
+ return TRUE;
}
-static void cpaste (tilda_window *tw)
+static gint cpaste (tilda_window *tw)
{
DEBUG_FUNCTION ("cpaste");
DEBUG_ASSERT (tw != NULL);
@@ -244,6 +247,9 @@ static void cpaste (tilda_window *tw)
current_page = gtk_notebook_get_nth_page (GTK_NOTEBOOK (tw->notebook), pos);
list = gtk_container_get_children (GTK_CONTAINER (current_page));
vte_terminal_paste_clipboard (VTE_TERMINAL(list->data));
+
+ /* Stop the event's propagation */
+ return TRUE;
}
static gint tilda_window_setup_keyboard_accelerators (tilda_window *tw)
--
1.5.3.7
