Robert Luberda wrote:
> Mohammed Adnène Trojette writes:
>> Hi Robert and happy new year.
> 
> Hi and happy new year to you too ;)

Hi, happy new year.

>> If not, please could you explain the exact problem?
> 
> 
> man2html_1.6e.orig.tar.gz contains man-1.6e.tar.gz which debdiff
> extracts in /tmp/foo/man2html-1.6e/man-1.6e directory
> 
> man2html_1.6f.orig.tar.gz contains man-1.6f.tar.gz which is extracted
> into /tmp/bar/man2html-1.6f/man-1.6f.
> 
> Then debdiff calls
>  diff -Nur /tmp/foo/man2html-1.6e /tmp/bar/man2html-1.6f
> which shows all the files from man-1.6e as removed
> and all the files from man-1.6f as added.

Yes, which is way better than just showing that a file was removed and
another one added. It also makes clear how stupid it is to have tarballs
in orig.tar.gz IMHO

Though feel free to attach a patch to 'fix' this and we'll probably
include it.

>>> I think you can reproduce the bug on most source packages which
>>> contain *.tar.gz tarballs (tzdata is one of exceptions). Fortunatelly
>>> there's a typo
>>> in debdiff which prevents *.tar.bz2 tarballs for being unpacked.
>>
>> Please could you point at the typo so that it gets fixed too? :-)
> 
> line 471:
>  if ($_ =~ /tar.bz$/) {
> but it would be better if this doesn't get fixed ;)

On the contrary, fixed it in the repository.

Cheers

Luk



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to