tags 451521 fixed-upstream
thanks

Hello,

On Fri, Nov 16, 2007 at 03:42:32PM +0100, [EMAIL PROTECTED] wrote:
> 
> I'm sending a small patch to improve logging of login.  When getpwnam() fails 
> inside the PAM section, login
> would just silently quit, which caused me a considerable amount of pain while 
> debugging my setup.  I thought,
> I'd help avoid others falling into that trap in the future.

Thanks for the patch.

I did not apply this patch, but another which should also solve your
issue.

 * setup_groups already log information about the issue, so an additional
   log is not required.
 * if the password entry could not be retrieved, it is not recommended to
   log the username: users sometimes enter their password instead of
   login.
   This is the default behavior, which can be turned off with
   LOG_UNKFAIL_ENAB in /etc/login.defs.

Please find attached the patch applied upstream for the next version.
-- 
Nekral
?      shadow-4.0.18.2.tar.bz2
?      man_po
?      gen_translations.sh
?      table_translations_doc.php
?      table_translations_bin.php
?      src/usermod.c.nf
?      src/userdel.c.nf
M      src/login.c
M      ChangeLog

Reply via email to