Tony Houghton schrieb: > On Thu, 08 Nov 2007 21:46:17 +0100 > Michael Biebl <[EMAIL PROTECTED]> wrote: > >> thanks for your suggestions. Instead of hiding the popups completely >> I'd prefer a similar mechanism like is used in gnome-power-manager. >> Show them by default, present a button in the tooltip saying "Don't >> show this ... anymore", which when pressed, set's the gconf key to >> false. Could you rework the patch to do that? > > OK, I've managed to do that. I've added a menu entry as well as the > button in the popup so that it can easily be enabled again. > > There are maybe a few things that could be cleaned up, but I'm confident > it works correctly. There are a few new strings that need adding to the > translations but that's beyond me. > > I've split the patch up into two - the main changes I made and the > changes it causes to the files generated by autotools etc - to make it > easier to maintain. > >
There seems to be something broken with the patch. The schema file is installed into /@GCONF_SCHEMA_FILE_DIR@/... It seems, that gconf-2.m4 must somehow be included in aclocal.m4 (either via acinclude.m4 or by intalling it into m4/ and setting AC_CONFIG_MACRO_DIR in configure.ac. I also assume that you have to call AM_GCONF_SOURCE_2 in configure.ac. Besides from that, the patch seems to work. The main concern now is the translations. I'm a bit reluctant to ship this patch with missing translations. If you can send me a fix for the issue above, I'll forward it to the upstream mailing list to see if upstream would be ok with it. Cheers, Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
signature.asc
Description: OpenPGP digital signature
