Bug#396378: gcal: [German holidays] All Saints Day no holiday for some states

[Marc-Jano Knopp]

On Tue, 31 Oct 2006, at 13:32:33 (+0100), Marc-Jano Knopp wrote:
> Package: gcal
> Version: 3.01.1-5.1
> Severity: normal
> 
> According to
> 
>   gcal -qDE_BA 11,
>   gcal -qDE_BW 11, and
>   gcal -qDE_RP 11,
> 
> All Saints Day (1st of November) is no legal holiday in Bavaria,
> Baden-Württemberg, and Rhineland Palatinate, which is wrong. In all
> these states, All Saints Day is a legal holiday,
[...]

While patching gcal to fix the above error, I found this peculiarity:
For the three states above,

  gcal -CE -q$STATE 11

listed All Saints Day as legal holiday, although it was still not
highlighted in the calender format. I haven't investigated this quirk
further, but with my patch, everything looks okay now.


After applying the attached patch, All Saints Day is always listed and
highlighted correctly for DE_{BA,BW,RP}.


Regards

  Marc-Jano

--- src/hd-data3.c.orig 2000-06-14 03:00:01.000000000 +0200
+++ src/hd-data3.c      2007-10-18 10:51:43.000000000 +0200
@@ -80,6 +80,8 @@ de_ba_hdy (init_data, detected, easter, 
    de_nw_hdy (init_data, detected, easter, year, hd_elems, fday, count);
    use_other_cc = !use_other_cc;
    de_hdy (init_data, detected, easter, year, hd_elems, fday, count);
+   holiday (*init_data, detected, _(hd_text[HD_ALL_SAINTS_DAY].ht_text),
+            ptr_cc_id, "+", DAY_MIN, 11, year, hd_elems, fday, count);
    holiday (*init_data, detected, _(hd_text[HD_MARYS_ASCENSION_DAY].ht_text),
             ptr_cc_id, "#", 15, 8, year, hd_elems, fday, count);
    holiday (*init_data, detected, _(hd_text[HD_THREE_KINGS_DAY].ht_text),
@@ -191,6 +193,8 @@ de_bw_hdy (init_data, detected, easter, 
    de_nw_hdy (init_data, detected, easter, year, hd_elems, fday, count);
    use_other_cc = !use_other_cc;
    de_hdy (init_data, detected, easter, year, hd_elems, fday, count);
+   holiday (*init_data, detected, _(hd_text[HD_ALL_SAINTS_DAY].ht_text),
+            ptr_cc_id, "+", DAY_MIN, 11, year, hd_elems, fday, count);
    holiday (*init_data, detected, _(hd_text[HD_THREE_KINGS_DAY].ht_text),
             ptr_cc_id, "+", 6, MONTH_MIN, year, hd_elems, fday, count);
 }
@@ -335,6 +339,8 @@ de_rp_hdy (init_data, detected, easter, 
    de_nw_hdy (init_data, detected, easter, year, hd_elems, fday, count);
    use_other_cc = !use_other_cc;
    de_hdy (init_data, detected, easter, year, hd_elems, fday, count);
+   holiday (*init_data, detected, _(hd_text[HD_ALL_SAINTS_DAY].ht_text),
+            ptr_cc_id, "+", DAY_MIN, 11, year, hd_elems, fday, count);
 }