Hello Michael,
Thanks again for the patch review.
On Wed, Oct 17, 2007 at 08:16:12AM +0200, [EMAIL PROTECTED] wrote:
>
> Applied for upstream 2.68, but see my comment about one point below.
> > @@ -146,7 +146,7 @@
> > in the child's memory.
> > As above, the two requests are currently equivalent.
> > .TP
> > -.B PTRACE_POKEUSR
> > +.B PTRACE_POKEUSER
>
> This is not correct. PTRACE_POKEUSR is right.
After checking, it is quite strange because:
/usr/include/linux/ptrace.h defines PTRACE_POKEUSR
(from the Debian package linux-libc-dev 2.6.22-4)
/usr/include/sys/ptrace.h defines PTRACE_POKEUSER
(from the Debian package libc6-dev 2.6.1-5)
Also, the man2 ptrace page mentions both PTRACE_POKEUSR and
PTRACE_POKEUSER (in the description of PTRACE_SETREGS and PTRACE_SETFPREGS).
Are these ptrace requests standardized in SVr4 and 4.3BSD?
I guess the glibc shall define PTRACE_POKEUSR (and redefine
PTRACE_POKEUSER as an alias for backward compatibility).
(and the same for he PEEK request)
Kind Regards,
--
Nekral
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
