This one time, at band camp, gregor herrmann said: > On Sun, 16 Sep 2007 20:54:25 +0200, gregor herrmann wrote: > > > t/pod_coverage.... > > # Failed test 'Pod coverage on Business::ISBN' > > # in t/pod_coverage.t at line 14. > > # Coverage for Business::ISBN is 92.9%, with 2 naked subroutines: > > # isbn_group_code_string_from_number > > # isbn_publisher_ranges_from_group_number > > # Looks like you failed 1 test of 1. > > dubious > > Test returned status 1 (wstat 256, 0x100) > > DIED. FAILED test 1 > > Failed 1/1 tests, 0.00% okay > > The "naked subroutines" isbn_group_code_string_from_number and > isbn_publisher_ranges_from_group_number are not in > libbusiness-isbn-perl but in libbusiness-isbn-data-perl.
The attached patch fixes it by excluding the symbols that come from the parent class. It looks like Pod::Coverage or Devel::Symdump should have noticed that when traversing the tree, but it's hard to say. (Note - I don't think I need to NMU, just saw the bug float by and made a fast patch. The NMU bit is an artifact of dch and nmudiff). Cheers, -- ----------------------------------------------------------------- | ,''`. Stephen Gran | | : :' : [EMAIL PROTECTED] | | `. `' Debian user, admin, and developer | | `- http://www.debian.org | -----------------------------------------------------------------
diff -u libbusiness-isbn-perl-2.02/debian/changelog libbusiness-isbn-perl-2.02/debian/changelog
--- libbusiness-isbn-perl-2.02/debian/changelog
+++ libbusiness-isbn-perl-2.02/debian/changelog
@@ -1,3 +1,10 @@
+libbusiness-isbn-perl (2.02-1.1) unstable; urgency=low
+
+ * Non-maintainer upload.
+ * Fix for FTBFS in Pod::Coverage test (closes: #442764)
+
+ -- Stephen Gran <[EMAIL PROTECTED]> Mon, 17 Sep 2007 01:35:06 +0100
+
libbusiness-isbn-perl (2.02-1) unstable; urgency=low
* New upstream release.
only in patch2:
unchanged:
--- libbusiness-isbn-perl-2.02.orig/t/pod_coverage.t
+++ libbusiness-isbn-perl-2.02/t/pod_coverage.t
@@ -13,7 +13,7 @@
pod_coverage_ok( "Business::ISBN",
{
- trustme => [ qr/^[A-Z_]+$/ ],
+ trustme => [ qr/^([A-Z_]+|isbn_publisher_ranges_from_group_number|isbn_group_code_string_from_number)$/ ],
}
);
}
signature.asc
Description: Digital signature
