Chung-chieh Shan wrote:
Package: laptop-mode-tools
Version: 1.34-1
Severity: normal
Tags: patch
Hello,
/etc/init.d/laptop-mode creates a temporary file without removing it
every time it is run, because it invokes rm only on abnormal exit.
The numerous occurrences of
$( cat $TEMPFILE )
in this script are underquoted: where it is double quoted, it should
be single quoted so that cat is not run too early, and where it is
unquoted, it should be double quoted so that the output of laptop_mode
is not subject to globbing. Finally, these uses of temporary files
are unnecessary because the shell can directly turn the output of
laptop_mode into an argument to log_action_end_msg.
The following patch fixes these problems.
Thanks,
Ken
Hi Ken,
Good points, the current situation _is_ definitely wrong. I'll apply
your patch in the next release. Thanks very much for helping!
Cheers,
Bart
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
