Forwarded message with the fix.
----- Forwarded message from Stephan Springl <[EMAIL PROTECTED]> -----
From: Stephan Springl <[EMAIL PROTECTED]>
To: Michal Suchanek <[EMAIL PROTECTED]>,
Steve Langasek <[EMAIL PROTECTED]>
Subject: Your patch 038_support_hurd in debian PAM
Date: Wed, 29 Aug 2007 12:15:59 +0200 (MSZ)
X-SA-Exim-Connect-IP: 222.222.222.4
X-SA-Exim-Mail-From: [EMAIL PROTECTED]
X-SA-Exim-Scanned: No (on mail.bfw-online.de); SAEximRunCond expanded to false
Hello Michal, hello Steve,
your patch included in debian sid pam-0.99.7.1 prefers using getline over
fgets with a static buffer. It introduces a problem because getline
returns -1 on read, including end of file. This means that the reading
loop will never terminate and services using pam_rhosts_auth will loop
forever.
Something like this helps us:
--- ./x/pam-0.99.7.1/debian/patches-applied/038_support_hurd 2007-08-29
11:23:30.000000000 +0200
+++ ./y/pam-0.99.7.1/debian/patches-applied/038_support_hurd 2007-08-29
11:42:15.000000000 +0200
@@ -29,7 +29,7 @@
+ int buflen=0;
- buf[sizeof (buf)-1] = '\0'; /* terminate line */
-+ while (getline(&buf,&buflen,hostf)) {
++ while (getline(&buf,&buflen,hostf) != -1) {
+#else
+ char buf[MAXHOSTNAMELEN + 128]; /* host + login
*/
Thank you.
Stephan
----- End forwarded message -----
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
[EMAIL PROTECTED] http://www.debian.org/
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
