> > So, you're proposing the following workflow is better > > > > git-add XXX > > git-add YYY > > git-status (check what's going to be committed) > > git-diff --cached (check the actual diff to be committed) > > debcommit > > > > rather than > > > > git-status (check what's going to be committed) > > git-diff (check what's to be committed) > > debcommit > > Yes. Git's index and the necessity to call git add after every > change is awesome; I can make changes to more than one file but then > use git add or even git add -i to selectively choose which hunks to > make part of the debcommit.
Thanks. 'git-add -i ' killed me. Cool.
> > Iff using index files is useful; I propose creating the following
> > three different scenarios, and adopt other SCMs to it. It will change
> > debcommit behavior on different SCMs.
> >
> > 1. commit what's in git-index (those which have been added with
> > git-add).
> >
> > debcommit (without any options)
>
> Yes, that's what my patch does, I think.
>
> > 2. commit what's specified on the command-line
> >
> > debcommit fileA fileB fileC
> >
> > which will do
> >
> > git-diff fileA fileB fileC
>
> You only need to diff debian/changelog, right?
I had an impression that the code should diff everything as committed,
and find 'debian/changelog'. The effect should be so that, if you
didn't include debian/changelog in your commit, you get an error and
debcommit will barf out. However, it isn't. If you didn't add
debian/changelog explicitly in the command-line you get a commit
without debian/changelog; which is a different 'bug' to the one we're
trying to discuss.
> > Comments?
> >
> > This will need modification in the manual, and will have an
> > undecided behavior for 'debcommit' for other SCMs. I would
> > suggest making debcommit do nothing, or implicitly do '-a'. Of
> > course, this deviation will put off some users of other SCMs when
> > they move to git, but of course, git users are too special.
>
> I suggest to implicitly do -a. Moving to git already includes
> learning about the index, and I think most users will appreciate the
> additional control, especially those special git users. :)
>
> If we add a warning when git is in use (like my patch does), it'll
> be enough of a cluebat too, I think.
There are technical people who like that detail, but imo, they can use git
directly.
That said. I've revised your patch; attached.
regards,
junichi
--
[EMAIL PROTECTED],netfort.gr.jp} Debian Project
debcommit.pl
Description: Binary data
dif
Description: Binary data
