Package: logrotate
Version: 3.7.1-3
Severity: wishlist

from debian/patches/rh-dateext.patch:


This was added in the dateext case:

+       /* firstRotated is most recently created/compressed rotated log */
+       sprintf(firstRotated, "%s/%s-%04d%02d%02d%s%s",
+               dirName, baseName, now.tm_year+1900,
+               now.tm_mon+1, now.tm_mday, fileext, compext);

This remained in the non-dateext:

     sprintf(firstRotated, "%s/%s.%d%s%s", dirName, baseName,
             logStart, fileext, 
            (log->flags & LOG_FLAG_DELAYCOMPRESS) ? "" : compext);

Note the disapprearance/lack of the 'compext only if not delaycompress'
logic. I don't know actual impact of this, though. Probably best
forwarded to RedHat (the patch authors), to me it seems (from a
perfectionists pov) better to rework the code to not calculate
firstRotated in advance but simply store it once actually rotated for
the first time -- much less errorprone.

Set at 'wishlist' because no actual behaviour bug found.

--Jeroen


-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-4-k7
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages logrotate depends on:
ii  base-passwd                 3.5.11       Debian base system master password
ii  cron                        3.0pl1-100   management of regular background p
ii  libc6                       2.3.6.ds1-13 GNU C Library: Shared libraries
ii  libpopt0                    1.10-3       lib for parsing cmdline parameters
ii  libselinux1                 1.32-3       SELinux shared libraries

Versions of packages logrotate recommends:
ii  mailx            1:8.1.2-0.20050715cvs-1 A simple mail user agent

-- no debconf information


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to