On Sat, Jun 23, 2007 at 09:17:24PM +0100, Raphael Hertzog wrote: > It creates a set of modules in /usr/lib/dpkg/Dpkg/ as I need some shared > code between dpkg-gensymbols and dpkg-shlibdeps. > > There's no documentation update yet, but I shall work on that once the > code is integrated. I'll maintain that code over time and do any possible > bugfixes and enhancements that may appear. > > I expect at least some enhancements in the way we handle the symbols files > over the set of architectures (ie to share some information instead of > having simply debian/package.symbols.arch).
Ok. I would be willing to start integrating this into dpkg. I don't like the overall quality of the code, though. It might not be bad compared to the code that can currently be found in dpkg-dev, but it doesn't really measure up to any objective standards (e.g. there are too many open calls that use the older, much more insecure and somwhat slower syntax). My proposed plan would be to: 1) Apply the part of the patch that adds the modules. Since that doesn't add anything useful to dpkg in its own right, we should probably make this in a branch 2) Do some code clean-up 3) Add a minimal test suite (no excuse not to do this for entirely new code!) Something simple with Test::More should suffice, but if someone prefers a more sophisticated framework, I will not stand in his way. 4) when satisfied with the result, apply the rest of the patch 5) Merge to trunk/ I would give Raphael commit rights to the repository with the understanding that he limits himself to the branch integrating his work for now (I really see no need for technical measures enforcing that, we are all grown-ups, right?) Objections? Comments? Gruesse, -- Frank Lichtenheld <[EMAIL PROTECTED]> www: http://www.djpig.de/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
