On Jun 12, 2007, at 8:16, Daniel Burrows wrote:
At a quick glance, it looks to me like you've conflated two separate
changes: a fix to make removal of directory trees work, and a fix for
renaming files. Your fix for renaming files looks like it should
work just fine: I fixed renames by copying up-front and
letting .remove
unlink the file; you did an up-front move and don't unlink in .remove.
Right, I dealt with the problems I ran into. Something I was
importing had a directory-related move.
Either approach should work. The only other difference is that I
used
the mercurial.util copy function, but that was mostly because someone
told me that mercurial itself uses this; I have no reason to think
that
shutil's copy/move are worse.
I used shutil because I have no idea what mercurial.util is. :)
The only thing I don't understand in your change is the comment
about
disjunct trees. Is that something to do with the the source and
target
repositories having the same working directory?
Right. Some of my fixes worked when both revision control systems
were in the same directory, but didn't when they were separate.
--
Dustin Sallings
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
