On Sat, May 12, 2007 at 10:20:58AM -0300, Otavio Salvador wrote:
David Härdeman <[EMAIL PROTECTED]> writes:

Please review.

Hello David,

There're some indentation mistakes (mixing tabs and spaces) and also I
don't like the  private_splash_progress method name. A better name
might be custom_splash_progress or my_splash_progress. Private looks
like something that ought not be touched.

Sounds reasonable...I wont post a new file though since that should be trivial to change for whoever commits them (if someone asks for it I can of course do it).

--
David Härdeman


Reply via email to