tag 412826 patch
notforwarded 412826
thanks
On Wed, Feb 28, 2007 at 01:03:45PM +0100, Oskar Liljeblad wrote:
> Package: smokeping
> Version: 2.0.9-2
> Severity: normal
>
> Take a look at the two attached graphs. They are generated from the same data.
> Values in the graph from 11:00 to ~13:00 ranges from ~30 ms to ~87ms.
> If you check the same duration in the second graph, the values now range from
> ~30ms to ~235ms.
> Could it be that in the "zoomed in" graph (10:00..13:00) isn't scaled
> correctly,
> and that the top grey bar that doesn't fit completely is not rendered at all?
Hi,
the scaling is correct, but any smoke that doesn't fit in the scale is
indeed currently not rendered at all. This is a bug, and I'm attaching
a patch that fixes it. The patch will be included in the next upstream
release (2.1.2) and the next Debian package (probably based on 2.1.1,
unless 2.1.2 is released soon.)
The scaling concentrates on the median (the green line) on purpose;
the smoke is not the most interesting thing here. With the patch any
smoke that doesn't fit will just go all the way to the top of the graph.
Thanks for reporting this,
--
Niko Tyni [EMAIL PROTECTED]
--- lib/Smokeping.pm (revision 738)
+++ lib/Smokeping.pm (revision 739)
@@ -1006,7 +1006,7 @@
'--color', 'BACK#ffffff',
'--color', 'CANVAS#ffffff',
(map {"DEF:ping${_}=${rrd}:ping${_}:AVERAGE"} 1..$pings),
- (map {"CDEF:cp${_}=ping${_},0,$max->{$start},LIMIT"} 1..$pings),
+ (map {"CDEF:cp${_}=ping${_},$max->{$start},MIN"} 1..$pings),
("DEF:loss=${rrd}:loss:AVERAGE"),
@upargs,# draw the uptime bg color
@lossargs, # draw the loss bg color
