Package: nstx
Version: 1.1-beta6-4
Severity: important

nstxcd does not mark packets which exactly fit a DNS query as "final".

diff -rub nstx-1.1-beta6/debian/changelog nstx/debian/changelog
--- nstx-1.1-beta6/debian/changelog     2007-05-06 10:43:37.000000000 +0200
+++ nstx/debian/changelog       2007-05-06 10:44:50.000000000 +0200
@@ -1,3 +1,10 @@
+nstx (1.1-beta6-5) unstable; urgency=low
+
+  * Packets which exactly fit a DNS query need to be marked as "last packet",
+    otherwise the server won't decode them.
+
+ -- Matthias Urlichs <[EMAIL PROTECTED]>  Sun,  6 May 2007 10:43:46 +0200
+
 nstx (1.1-beta6-4) unstable; urgency=low
 
   * Fix segfault triggered by normal DNS traffic (closes: #345159)
Only in nstx: nstxcd
diff -rub nstx-1.1-beta6/nstxcd.c nstx/nstxcd.c
--- nstx-1.1-beta6/nstxcd.c     2007-05-06 10:43:37.000000000 +0200
+++ nstx/nstxcd.c       2007-05-05 22:27:19.000000000 +0200
@@ -143,13 +151,13 @@
     dns_setid(pkt, nsid);
     
     l = dns_getfreespace(pkt, DNS_QUERY);
-    if (l <= 0) {
+    if (l <= (int)sizeof(nh)) {
        printf("Fatal: no free space in dns-packet?!\n");
        exit(1);
     }
     p = malloc(l);
     l -= sizeof(nh);
-    if (l > datalen) {
+    if (l >= datalen) {
        l = datalen;
        nh.flags = NSTX_LF;
     }
-- System Information:
Debian Release: 4.0
  APT prefers feisty
  APT policy: (851, 'feisty'), (740, 'edgy'), (730, 'dapper'), (500, 
'feisty-updates'), (500, 'feisty-security'), (500, 'edgy-updates'), (500, 
'edgy-security'), (500, 'edgy-backports'), (500, 'dapper-updates'), (500, 
'dapper-security'), (500, 'dapper-backports')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/dash
Kernel: Linux 2.6.17-11-server
Locale: LANG=en_US.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8) (ignored: LC_ALL 
set to en_US.UTF-8)

Versions of packages nstx depends on:
ii  adduser                    3.100         Add and remove users and groups
ii  libc6                      2.5-0ubuntu14 GNU C Library: Shared libraries

nstx recommends no packages.

-- no debconf information


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to