Package: zapping Version: 0.9.2-2 Severity: wishlist Tags: patch
In the import code , the channel builder abort if a channel has no "channel" value. This happens to me as i had a channel for "magneto" with input=composite1 but obviously no channel frequency. In this case the import code just abort without warning, from the gui nothing happens. This patch had a check in the input import code to define the has_channel flag when input is not television , based on the idea that those are channel which don't need an xawtv"channel" parameter. It looks like it does not fit the design for the import code. Though this hack enable to work around this limitation (and i wonder if rewriting this piece of code for this special case is worth the trouble,) .the code for all the other cases is stable). Greetings Alban -- System Information: Debian Release: 3.1 APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: i386 (i686) Kernel: Linux 2.6.11-rc5 Locale: [EMAIL PROTECTED], [EMAIL PROTECTED] (charmap=UTF-8) Versions of packages zapping depends on: ii libart-2.0-2 2.3.17-1 Library of functions for 2D graphi ii libartsc0 1.3.2-3 aRts Sound system C support librar ii libatk1.0-0 1.9.0-1 The ATK accessibility toolkit ii libaudiofile0 0.2.6-6 Open-source version of SGI's audio ii libbonobo2-0 2.8.1-2 Bonobo CORBA interfaces library ii libbonoboui2-0 2.8.1-2 The Bonobo UI library ii libc6 2.3.4-2 GNU C Library: Shared libraries an ii libesd-alsa0 [libesd 0.2.35-2 Enlightened Sound Daemon (ALSA) - ii libgconf2-4 2.8.1-5 GNOME configuration database syste ii libgcrypt11 1.2.0-11 LGPL Crypto library - runtime libr ii libglade2-0 1:2.4.2-2 library to load .glade files at ru ii libglib2.0-0 2.6.3-1 The GLib library of C routines ii libgnome-keyring0 0.4.1-1 GNOME keyring services library ii libgnome2-0 2.10.0-1 The GNOME 2 library - runtime file ii libgnomecanvas2-0 2.10.0-1 A powerful object-oriented display ii libgnomeui-0 2.10.0-1 The GNOME 2 libraries (User Interf ii libgnomevfs2-0 2.8.4-2 The GNOME virtual file-system libr ii libgnutls11 1.0.16-13 GNU TLS library - runtime library ii libgpg-error0 1.0-1 library for common error values an ii libgtk2.0-0 2.6.2-4 The GTK+ graphical user interface ii libice6 4.3.0.dfsg.1-12.0.1 Inter-Client Exchange library ii libjpeg62 6b-10 The Independent JPEG Group's JPEG ii liblircclient0 0.7.1pre2-6 LIRC client library ii liborbit2 1:2.12.1-1 libraries for ORBit2 - a CORBA ORB ii libpango1.0-0 1.8.1-1 Layout and rendering of internatio ii libpng12-0 1.2.8rel-1 PNG library - runtime ii libpopt0 1.7-5 lib for parsing cmdline parameters ii libsm6 4.3.0.dfsg.1-12.0.1 X Window System Session Management ii libtasn1-2 0.2.10-4 Manage ASN.1 structures (runtime) ii libx11-6 4.3.0.dfsg.1-12.0.1 X Window System protocol client li ii libxext6 4.3.0.dfsg.1-12.0.1 X Window System miscellaneous exte ii libxml2 2.6.16-6 GNOME XML library ii libxmu6 4.3.0.dfsg.1-12.0.1 X Window System miscellaneous util ii libxv1 4.3.0.dfsg.1-12.0.1 X Window System video extension li ii libzvbi0 0.2.14-1 video Blank Interval decoder (VBI) ii python2.3 2.3.5-2 An interactive high-level object-o ii xlibs 4.3.0.dfsg.1-12 X Keyboard Extension (XKB) configu ii zlib1g 1:1.2.2-4 compression library - runtime -- no debconf information
diff -uNr zapping-0.9.2.orig/src/xawtv.c zapping-0.9.2/src/xawtv.c --- zapping-0.9.2.orig/src/xawtv.c 2005-01-08 15:54:29.000000000 +0100 +++ zapping-0.9.2/src/xawtv.c 2005-04-03 09:24:09.000000000 +0200 @@ -264,8 +264,12 @@ for (l = NULL; (l = tv_next_video_input (info, l));) if (0 == g_ascii_strcasecmp (l->label, value)) break; - if (l) + if (l) { tt_ch->input = l->hash; + /* non television input channel don't have a "channel" indent */ + if (l->label != "Television") + *have_channel = TRUE; + } } else if (0 == strcmp (ident, "norm")) {